chore(deps): update all dependencies and use webpack 5 #2858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylemkimon
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
ylemkimon
force-pushed
the
deps
branch
2 times, most recently
from
68c2131 to
8fff82c
Compare
Codecov Report
@@ Coverage Diff @@
## v4 #2858 +/- ##
==========================================
- Coverage 92.62% 92.46% -0.17%
==========================================
Files 38 38
Lines 1247 1247
Branches 326 326
==========================================
- Hits 1155 1153 -2
- Misses 87 89 +2
Partials 5 5
Continue to review full report at Codecov.
|
shaodahong
reviewed
Nov 25, 2020
| @@ -4,7 +4,9 @@ const SockJS = require('sockjs-client/dist/sockjs'); | |||
| const { log } = require('../default/utils/log'); | |||
| const BaseClient = require('./BaseClient'); | |||
|
|
|||
| module.exports = class SockJSClient extends BaseClient { | |||
| module.exports = class SockJSClient extends ( | |||
There was a problem hiding this comment.
prettier was updated to improve formatting for assignments of classes with long superclass names.
There was a problem hiding this comment.
Oh, thanks, weird for this to extra brackets, maybe fix by prettier/prettier#9744
issue link prettier/prettier#9341 (comment)
hiroppy
approved these changes
Nov 25, 2020
alexander-akait
approved these changes
Nov 25, 2020
|
Big thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
prettier: improve formatting for assignments of classes with long superclass nameswebpack-merge: merge has been moved as a regular importschema-utils: the packages exports was changedpuppeteer:waitForis deprecated (Proposal: deprecatewaitForand addwaitForTimeoutpuppeteer/puppeteer#6214)target: ['web', 'es5']for client sourcesBreaking Changes
N/A
Additional Info