Skip to content

BREAKING CHANGE: remove socket option #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

Remove socket option

Breaking Changes

socket option removed

Additional Info

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #2669 into v4 will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2669      +/-   ##
==========================================
- Coverage   92.53%   92.51%   -0.02%     
==========================================
  Files          37       37              
  Lines        1312     1310       -2     
  Branches      355      354       -1     
==========================================
- Hits         1214     1212       -2     
  Misses         93       93              
  Partials        5        5              
Impacted Files Coverage Δ
lib/utils/createConfig.js 95.06% <ø> (-0.12%) ⬇️
lib/utils/createDomain.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6c8f4...c287584. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still unstable 😞

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fails by audit and it hasn't fixed yet. anyway LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants