chore(deps): update deps #2577
Merged
chore(deps): update deps #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
force-pushed
the
feature/update-deps
branch
from
b76d2a2 to
3f62a82
Compare
hiroppy
commented
May 8, 2020
| "jest-junit": "^10.0.0", | ||
| "jquery": "^3.5.0", |
Codecov Report
@@ Coverage Diff @@
## v4 #2577 +/- ##
==========================================
- Coverage 93.41% 92.84% -0.58%
==========================================
Files 34 35 +1
Lines 1291 1313 +22
Branches 363 368 +5
==========================================
+ Hits 1206 1219 +13
- Misses 82 89 +7
- Partials 3 5 +2
Continue to review full report at Codecov.
|
hiroppy
force-pushed
the
feature/update-deps
branch
from
3f62a82 to
431ae5e
Compare
hiroppy
commented
May 8, 2020
| @@ -11,7 +11,7 @@ describe('CLI', () => { | |||
| testBin('--progress') | |||
| .then((output) => { | |||
| expect(output.exitCode).toEqual(0); | |||
| expect(output.stderr).toContain('0% compiling'); | |||
| expect(output.stderr).toContain('100%'); | |||
There was a problem hiding this comment.
hiroppy
force-pushed
the
feature/update-deps
branch
from
431ae5e to
778fd9a
Compare
hiroppy
commented
May 8, 2020
| @@ -29,7 +29,7 @@ describe('progress', () => { | |||
| let foundProgress = false; | |||
| let foundProfile = false; | |||
| calls.forEach((call) => { | |||
| if (call[0].includes('0% compiling')) { | |||
| if (call[0].includes('2%')) { | |||
There was a problem hiding this comment.
The previous webpack@next of beta was able to output 0% but the new version can't output this. I'll investigate this but anyway, this PR is okay.(progress feature can work).
hiroppy
force-pushed
the
feature/update-deps
branch
from
778fd9a to
123753d
Compare
alexander-akait
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Update.
Breaking Changes
no
Additional Info