test(client): check console.log #1907
Conversation
| setTimeout(() => { | ||
| expect(res).toMatchSnapshot(); | ||
| browser.close().then(resolve); | ||
| }, 3000); |
There was a problem hiding this comment.
Maybe here is flaky tests.
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 15 15
Lines 814 814
Branches 259 259
=======================================
Hits 716 716
Misses 84 84
Partials 14 14Continue to review full report at Codecov.
|
| exports[`Client console.log hot disabled 1`] = ` | ||
| Array [ | ||
| "Hey.", | ||
| "[WDS] Live Reloading enabled.", |
There was a problem hiding this comment.
Should it be output this line?
|
|
||
| exports[`Client console.log liveReload enabled 1`] = ` | ||
| Array [ | ||
| "Hey.", |
There was a problem hiding this comment.
We should expect [WDS] Live Reloading enabled.
There was a problem hiding this comment.
Yes, need investigate what is problem
|
|
||
| exports[`Client console.log liveReload enabled 1`] = ` | ||
| Array [ | ||
| "Hey.", |
There was a problem hiding this comment.
Yes, need investigate what is problem
|
client-src depends on browsers variables, e.g |
|
@hiroppy jest support jsdom and windows and other tools avaliable, but maybe it is bad idea try to use jsdom because many features are unavailable, so i think it is ok using this approach |
|
Anyway need investigate why some value invalid in tests as i written above |
Yeah, I agree with you.
I would like to investigate after merging this PR. |
hiroppy
dismissed stale reviews from alexander-akait and LoganKJohnson
via
aa0d9fb
hiroppy
force-pushed
the
feature/add-client-tests
branch
from
cac171b to
aa0d9fb
Compare
|
I just fixed lint. PTAL /cc @evilebottnawi |
|
And I'll start to investigate client code, so I need this pr. |
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
Just testing
console.logof the client's code.Breaking Changes
no
Additional Info
Maybe liveReload has a bug... see the snapshot.