Skip to content

add options test #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2019
Merged

add options test #1821

merged 3 commits into from
Apr 26, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Apr 26, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

I want to avoid forgetting to add an errorMessage when we add a property.

I added snapshots because #1819 has a big refactoring of options.json but I don' think they are not necessary. Maybe, I'll delete them after merging of #1819.

Breaking Changes

Additional Info

We should add documents about sockPort, injectClient and injectHot.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files           9        9           
  Lines         608      608           
  Branches      185      185           
=======================================
  Hits          533      533           
  Misses         63       63           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b501d...45336f0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants