Remove Sock injection when options.hot is false?

[plauclair]

• Operating System: macOS 10.14.4

• Node Version: 10.15.0

• NPM Version: 6.9.0

• webpack Version: 4.30.0

• webpack-dev-server Version: 3.3.1

• This is a bug

• This is a modification request

Code

const serverOptions = { hot: false };

Expected Behavior

When setting hot to false, socket is still added as a dependency. Maybe I understand wrong, but shouldn't dev server only serve when options.hot is false?

Actual Behavior

Current code always injects Socket dependency even if hot is disabled. Currently this can be achieved through options.inline = false but that seems to be something completely different.

https://github.com/webpack/webpack-dev-server/blob/master/lib/utils/addEntries.js#L21

For Features; What is the motivation and/or use-case for the feature?

We use dev server to serve files in an environment that does not support web sockets. Having the socks module crashes the process even when hot is false.

[alexander-akait]

hot !== sockjs, we use sockjs for getting new assets, maybe we can add option sockjs: true | false, PR welcome

[plauclair]

@evilebottnawi would gladly submit a PR. Anything special that comes to mind that would need to be taken into account?

[alexander-akait]

I think no

[alexander-akait]

We should not add client when hot is false, because it is doesn't have sense

[alexander-akait]

@plauclair i was wrong, we should not include client when hot and liveReload is false

[plauclair]

Makes sense, we have an issue open here, I'll try to squeeze in something this week. This makes it much easier to go about it.

[Simon-Tang]

Thanks for the updated PR (#2601). I think my use case would depend on this change going into the next release.

I'm splitting a part of my code into a bundle that is loaded client-side using CSS.paintWorklet.addModule('./paintlet.bundle.js'). Both the SockJS and WebSocket transport modes expect to have a global window object, however a PaintWorklet cannot access any.

Current workaround is to not use webpack-dev-server, although I would still need to serve my local assets under localhost in a separate process to prevent CORS issues with CSS.paintWorklet.addModule.