Skip to content

Commit 8db3fb0

Browse files
refactor: minimum require webpack version is 4
BREAKING CHANGE: minimum require `webpack` version is `4`
1 parent 4fa385c commit 8db3fb0

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

.travis.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,17 @@ matrix:
77
fast_finish: true
88
include:
99
- os: linux
10-
node_js: "7"
11-
env: WEBPACK_VERSION="2.2.0" JOB_PART=lint
10+
node_js: "10"
11+
env: WEBPACK_VERSION="4.15.0" JOB_PART=lint
1212
- os: linux
13-
node_js: "6"
14-
env: WEBPACK_VERSION="2.2.0" JOB_PART=test
15-
- os: linux
16-
node_js: "4.3"
17-
env: WEBPACK_VERSION="2.2.0" JOB_PART=test
13+
node_js: "10"
14+
env: WEBPACK_VERSION="4.15.0" JOB_PART=test
1815
- os: linux
19-
node_js: "7"
20-
env: WEBPACK_VERSION="2.2.0" JOB_PART=test
16+
node_js: "8"
17+
env: WEBPACK_VERSION="4.15.0" JOB_PART=test
2118
- os: linux
22-
node_js: "4.3"
23-
env: WEBPACK_VERSION="1.14.0" JOB_PART=test
19+
node_js: "6"
20+
env: WEBPACK_VERSION="4.15.0" JOB_PART=test
2421
before_install:
2522
- nvm --version
2623
- node --version

lib/loader.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ var compileExports = require("./compile-exports");
99

1010

1111
module.exports = function(content, map) {
12-
if(this.cacheable) this.cacheable();
1312
var callback = this.async();
1413
var query = loaderUtils.getOptions(this) || {};
1514
var moduleMode = query.modules;

lib/localsLoader.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ var compileExports = require("./compile-exports");
99

1010

1111
module.exports = function(content) {
12-
if(this.cacheable) this.cacheable();
1312
var callback = this.async();
1413
var query = loaderUtils.getOptions(this) || {};
1514
var moduleMode = query.modules;

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@
3434
"should": "^11.1.2",
3535
"standard-version": "^4.0.0"
3636
},
37+
"peerDependencies": {
38+
"webpack": "^4.0.0"
39+
},
3740
"scripts": {
3841
"lint": "eslint lib test",
3942
"test": "mocha",

0 commit comments

Comments
 (0)