Add error sinks #456
Closed
Add error sinks #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum - I had the thought that maybe this should actually be a pnext thing? Adding an argument feels a little clunky. Idle thoughts |
|
Thoughts on moving this past the v1? If it's not too urgent, maybe we can iterate on it as necessary in the future? |
|
Closing per #211 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP draft
I've loosely sketched out what function-local error sinks would look like. However after sketching them out I'm not totally sure what the point was. Is it just ergonomics? I don't think it makes much sense to introduce an ergonomics feature at this point, and besides using error scopes is really not that bad - and wrt threading, it's easy to see that a straight pushErrorScope/someCall/popErrorScope sequence is all on the same thread.
cc @cwfitzgerald
Issue: #211