Skip to content

Document that error scopes are thread-local #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

Document that error scopes are thread-local #454

merged 1 commit into from
Dec 4, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Dec 4, 2024 •
edited
Loading

Issue: #211
(dawn bug https://crbug.com/382096622)

@kainino0x kainino0x requested a review from lokokung December 4, 2024 02:09
@kainino0x kainino0x added threading Thread safety and WASM-JS threading problems errors Error reporting labels Dec 4, 2024
cwfitzgerald
cwfitzgerald approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Gucci To Me

@kainino0x
Copy link
Collaborator Author

Thanks!

@kainino0x kainino0x merged commit b74f922 into webgpu-native:main Dec 4, 2024
5 checks passed
@kainino0x kainino0x deleted the error-scope-thread-local branch December 4, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

@lokokung lokokung Awaiting requested review from lokokung

Assignees
No one assigned
Labels
errors Error reporting threading Thread safety and WASM-JS threading problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @cwfitzgerald