Skip to content
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

Event handlers are duplicated. #22

Closed
treshugart opened this issue Jul 1, 2016 · 0 comments
Closed

Event handlers are duplicated. #22

treshugart opened this issue Jul 1, 2016 · 0 comments
Assignees
@treshugart

Comments

@treshugart
Copy link
Contributor

If you render:

<Component onClick={handler} />

The handler will get rebound for every render because removeEventListener() isn't removing the handler. This is probably because of the case-sensitivity of event names. We should be using eventNameLc for all references to the event internally.
@treshugart treshugart added the bug label Jul 1, 2016
@treshugart treshugart self-assigned this Jul 1, 2016
treshugart added a commit that referenced this issue Jul 1, 2016
@treshugart
test(event): Add test to ensure event handlers aren't duplicated.
51c6579 
#22
treshugart added a commit that referenced this issue Jul 1, 2016
@treshugart
fix(event): Ensure event handlers aren't duplicated.
da1b31f 
#22
@treshugart treshugart mentioned this issue Jul 1, 2016
Merged
@joscha joscha closed this as completed in #23 Jul 1, 2016
joscha added a commit that referenced this issue Jul 1, 2016
@joscha
Merge pull request #23 from skatejs/22
621f01c 
#22 - Ensure event handlers aren't duplicated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@treshugart treshugart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@treshugart