Fix typos #744
Fix typos #744
Conversation
|
There's similar PR already provided #743, could you please use it as base for yours, so we can cover here things that has been missed there. |
| @@ -51,10 +51,10 @@ extension APIRequest { | |||
|
|
|||
| /// This bit of code is purposed to work with literal types that comes in ``Response`` in hexString type. | |||
| /// Currently it's just `Data` and any kind of Integers `(U)Int`, `Big(U)Int`. | |||
| if let LiteralType = Result.self as? LiteralInitiableFromString.Type { | |||
| if let LiteralType = Result.self as? LiteralInitableFromString.Type { | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -8,15 +8,15 @@ | |||
| import Foundation | |||
| import BigInt | |||
|
|
|||
| extension Int: LiteralInitiableFromString { } | |||
| extension Int: LiteralInitableFromString { } | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| /// More than that their notation (e.g. 0x12d) are don't fit with the default Numeric decoders behaviours. | ||
| /// So to work around that for generic cases we're going to force decode `APIResponse.result` field as `String` | ||
| /// and then initiate it | ||
| protocol LiteralInitiableFromString: APIResultType { | ||
| protocol LiteralInitableFromString: APIResultType { |
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -64,9 +64,9 @@ public struct IBAN { | |||
|
|
|||
| internal static func decodeToInts(_ iban: String) -> String { | |||
| let uppercasedIBAN = iban.replacingOccurrences(of: " ", with: "").uppercased() | |||
| let begining = String(uppercasedIBAN[0..<4]) | |||
| let beginning = String(uppercasedIBAN[0..<4]) | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -60,7 +60,7 @@ final public class Oracle { | |||
| /// | |||
| /// - Parameter array: `[[min], [middle], [max]]` 2 dimensional array | |||
| /// - Returns: `[min, middle, max].count == self.percentiles.count` | |||
| private func soft(twoDimentsion array: [[BigUInt]]) -> [BigUInt] { | |||
| private func soft(twoDimension array: [[BigUInt]]) -> [BigUInt] { | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -99,24 +99,24 @@ final public class Oracle { | |||
| /// - Returns: `[percentile_1, percentile_2, percentile_3, ...].count == self.percentile.count` | |||
| /// by default there's 3 percentile. | |||
| private func suggestTipValue() async throws -> [BigUInt] { | |||
| var rearrengedArray: [[BigUInt]] = [] | |||
| var rearrangedArray: [[BigUInt]] = [] | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -219,53 +219,53 @@ extension CodableTransaction: Codable { | |||
|
|
|||
| public func encode(to encoder: Encoder) throws { | |||
| // FIXME: There's a huge mess here, please take a look here at code review if any. | |||
| var containier = encoder.container(keyedBy: CodingKeys.self) | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -54,7 +54,7 @@ public struct LegacyEnvelope: AbstractEnvelope { | |||
| toReturn += "Data: " + self.data.toHexString().addHexPrefix().lowercased() + "\n" | |||
| toReturn += "Resolved chainID: " + String(describing: self.chainID) + "\n" | |||
| toReturn += "- Intrinsic chainID: " + String(describing: self.explicitChainID) + "\n" | |||
| toReturn += "- Infered chainID: " + String(describing: self.impliedChainID) + "\n" | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
| @@ -100,7 +100,7 @@ fileprivate extension EIP712Hashable { | |||
| } | |||
|
|
|||
| func encodePrimaryType() -> String { | |||
| let parametrs: [String] = Mirror(reflecting: self).children.compactMap { key, value in | |||
There was a problem hiding this comment.
Please undo this changes, as they affecting code, rather then comments and should be reviewed separately.
|
Seems like mistakes one, so it would be closed. |
No description provided.