Skip to content

Commit fbd94be

Browse files
authored
Fix incorrect "same status" comment when status override is used (#1328)
For a few features, the comment was added incorrectly based on what the computed status was, but the computed status is never written to dist if the source includes an override.
1 parent b82b4ae commit fbd94be

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

features/scroll-snap.yml.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ compat_features:
8585
# safari_ios: "11"
8686
- css.properties.scroll-snap-type
8787

88-
# ⬇️ Same status as overall feature ⬇️
8988
# baseline: low
9089
# baseline_low_date: 2022-07-26
9190
# support:

features/web-bluetooth.yml.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ compat_features:
7575
- api.BluetoothRemoteGATTCharacteristic.writeValueWithResponse
7676
- api.BluetoothRemoteGATTCharacteristic.writeValueWithoutResponse
7777

78-
# ⬇️ Same status as overall feature ⬇️
7978
# baseline: false
8079
# support: {}
8180
- api.Bluetooth.getDevices

scripts/dist.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ function toDist(sourcePath: string): YAML.Document {
192192
const sortedGroups = new Map<string, string[]>();
193193
for (const status of sortedStatus) {
194194
let comment = YAML.stringify(status);
195-
if (isDeepStrictEqual(status, computedStatus)) {
195+
if (isDeepStrictEqual(status, source.status ?? computedStatus)) {
196196
comment = `⬇️ Same status as overall feature ⬇️\n${comment}`;
197197
}
198198
sortedGroups.set(comment, groups.get(status));

0 commit comments

Comments
 (0)