Skip to content

Commit 9e1501f

Browse files
authored
fix: not inline scripts / styles when enable not set (#3258)
1 parent d49912e commit 9e1501f

File tree

2 files changed

+35
-4
lines changed

2 files changed

+35
-4
lines changed

e2e/cases/inline-chunk/index.test.ts

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,3 +356,34 @@ test('inline does not work in development mode when enable is auto', async ({
356356
),
357357
).resolves.toEqual(1);
358358
});
359+
360+
test('styles and scripts are not inline by default in development mode when enable not set', async ({
361+
page,
362+
}) => {
363+
const rsbuild = await dev({
364+
cwd: __dirname,
365+
rsbuildConfig: {
366+
tools: toolsConfig,
367+
output: {
368+
inlineStyles: true,
369+
inlineScripts: /\.js$/,
370+
},
371+
},
372+
});
373+
374+
await gotoPage(page, rsbuild);
375+
376+
// all index.js in page
377+
await expect(
378+
page.evaluate(
379+
`document.querySelectorAll('script[src*="index.js"]').length`,
380+
),
381+
).resolves.toEqual(1);
382+
383+
// all index.css in page
384+
await expect(
385+
page.evaluate(
386+
`document.querySelectorAll('link[href*="index.css"]').length`,
387+
),
388+
).resolves.toEqual(1);
389+
});

packages/core/src/plugins/inlineChunk.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,9 @@ export const pluginInlineChunk = (): RsbuildPlugin => ({
240240

241241
if (inlineScripts) {
242242
if (inlineScripts === true) {
243-
scriptTests.push(JS_REGEX);
243+
isProdMode && scriptTests.push(JS_REGEX);
244244
} else if (isRegExp(inlineScripts) || isFunction(inlineScripts)) {
245-
scriptTests.push(inlineScripts);
245+
isProdMode && scriptTests.push(inlineScripts);
246246
} else {
247247
const enable =
248248
inlineScripts.enable === 'auto'
@@ -256,9 +256,9 @@ export const pluginInlineChunk = (): RsbuildPlugin => ({
256256

257257
if (inlineStyles) {
258258
if (inlineStyles === true) {
259-
styleTests.push(CSS_REGEX);
259+
isProdMode && styleTests.push(CSS_REGEX);
260260
} else if (isRegExp(inlineStyles) || isFunction(inlineStyles)) {
261-
styleTests.push(inlineStyles);
261+
isProdMode && styleTests.push(inlineStyles);
262262
} else {
263263
const enable =
264264
inlineStyles.enable === 'auto' ? isProdMode : inlineStyles.enable;

0 commit comments

Comments
 (0)