Skip to content

fix: should only watch file-based routes changes #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

fix: should only watch file-based routes changes #3742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef4eda
fix: should only watch file-based routes
zllkjc May 23, 2023
af06384
docs: change changeset
zllkjc May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/sour-cobras-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@modern-js/app-tools': patch
---

fix: should only watch file-based routes changes
fix: 只有基于文件的路由（约定式路由）需要被监听变化
3 changes: 2 additions & 1 deletion packages/solutions/app-tools/src/analyze/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ export default ({

pagesDir = entrypoints
.map(point => point.entry)
.filter(Boolean)
// should only watch file-based routes
.filter(entry => entry && !path.extname(entry))
.concat(nestedRouteEntries);

originEntrypoints = cloneDeep(entrypoints);
Expand Down