Skip to content

Last line of command output can get cut off in certain circumstances #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sawka opened this issue Feb 18, 2024 · 1 comment
Closed

Last line of command output can get cut off in certain circumstances #302

sawka opened this issue Feb 18, 2024 · 1 comment
Labels
bug Something isn't working legacy Issue pertaining to WaveLegacy

Comments

@sawka
Copy link
Member

sawka commented Feb 18, 2024

From Discord. A user is seeing the last line of command output get cut off. More of the line is cut off as more lines are displayed (gets worse as the number of lines of output increases).

Need to debug why there is a mismatch between the actual size of the terminal and the calculated size of the terminal.

Could this be related to pixel rounding? Zoom level? Font sizes (descenders)? Screen resolutions (native screen zooming).

@sawka sawka added the bug Something isn't working label Feb 18, 2024
@sawka
Copy link
Member Author

sawka commented Feb 18, 2024

ah, it is a timing issue. if we try to calculate the font metrics before the JetBrains Mono font is loaded we get font metrics for the default "monospace" font. That font has a different size (smaller). So we calculate the size of the terminal divs to be too small consistently. We don't actually see the monospace font because by the time the terminals render the font has loaded.

sawka added a commit that referenced this issue Feb 19, 2024
@sawka sawka closed this as completed in 07ad5f0 Feb 19, 2024
@sawka sawka reopened this Feb 20, 2024
sawka added a commit that referenced this issue Feb 20, 2024
…hen devicePixelRatio was not an integer leading to mis-sized terminal windows and cut off lines #302
sawka added a commit that referenced this issue Feb 20, 2024
…hen devicePixelRatio was not an integer leading to mis-sized terminal windows and cut off lines #302 (#305)
@sawka sawka closed this as completed Feb 23, 2024
sawka pushed a commit that referenced this issue Sep 18, 2024
@esimkowitz esimkowitz added the legacy Issue pertaining to WaveLegacy label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working legacy Issue pertaining to WaveLegacy
Projects
None yet
Development

No branches or pull requests

2 participants