Skip to content

Add mill cert example #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Conversation

OR13
Copy link
Collaborator

@OR13 OR13 commented Dec 12, 2019

  • Added example vc-json-schema document for steel mill cert test report
  • Added example vc for steel mill cert test report which uses the schema
  • Added test for signing the the schema with jsonld
  • Added test for issuing/verifying the steel mill cert test report vc
  • Added test for verifying the unsigned mill cert vc matches the vc-json-schema

@OR13 OR13 requested a review from decentralgabe as a code owner December 12, 2019 02:29
@OR13
Copy link
Collaborator Author

OR13 commented Dec 12, 2019

Sorry this is one commit :(

I spent a lot of time sanity checking jsonld issues, and chasing documentLoader bugs... still 35 changes in 1 commit is pretty sad.

@OR13 OR13 mentioned this pull request Dec 12, 2019
@decentralgabe
Copy link
Collaborator

I am not qualified to review javascript, but the rest looks good

@OR13
Copy link
Collaborator Author

OR13 commented Dec 12, 2019

I'm gonna gather a bit more feedback from team / community before merging this.

Copy link
Member

@gjgd gjgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is not passing on my machine. What version on node does this require?

Screenshot 2019-12-12 at 09 43 59

@OR13
Copy link
Collaborator Author

OR13 commented Dec 12, 2019

@gjgd requires node 12

@wyc
Copy link

wyc commented Dec 12, 2019

Tests pass on my end:

% node --version
v13.3.0

Results:

Test Suites: 3 passed, 3 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        5.113s
Ran all test suites.

@OR13 OR13 merged commit 91dfd7b into master Dec 13, 2019
@decentralgabe decentralgabe deleted the feat/add-hypothetical-millcert-example branch November 7, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants