-
Notifications
You must be signed in to change notification settings - Fork 8
Add mill cert example #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OR13
commented
Dec 12, 2019
- Added example vc-json-schema document for steel mill cert test report
- Added example vc for steel mill cert test report which uses the schema
- Added test for signing the the schema with jsonld
- Added test for issuing/verifying the steel mill cert test report vc
- Added test for verifying the unsigned mill cert vc matches the vc-json-schema
Sorry this is one commit :( I spent a lot of time sanity checking jsonld issues, and chasing documentLoader bugs... still 35 changes in 1 commit is pretty sad. |
...tical-use-cases/trade-certificates/examples/steel-mill-cert-test-report/unsigned.schema.json
Show resolved
Hide resolved
hypothetical-use-cases/trade-certificates/examples/steel-mill-cert-test-report/unsigned.vc.json
Show resolved
Hide resolved
I am not qualified to review javascript, but the rest looks good |
I'm gonna gather a bit more feedback from team / community before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gjgd requires node 12 |
Tests pass on my end:
Results:
|