Skip to content

More azaroth fixes #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2019
Merged

More azaroth fixes #271

merged 2 commits into from
Sep 28, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Sep 27, 2019 •
edited by pr-preview bot
Loading

@gkellogg gkellogg requested a review from azaroth42 September 27, 2019 19:48
azaroth42
azaroth42 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@azaroth42 azaroth42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, go Giants!

@gkellogg gkellogg merged commit d28d3de into master Sep 28, 2019
@gkellogg gkellogg deleted the more-azaroth-fixes branch September 28, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaroth42 azaroth42 azaroth42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe scoped context with @base for id map? Examples 91 & 92 very confusing, especially given language maps
2 participants
@gkellogg @azaroth42