Skip to content

add missing @none in step 13.4, addressing #259 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2019
Merged

add missing @none in step 13.4, addressing #259 #268

merged 2 commits into from
Dec 20, 2019

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Dec 20, 2019 •
edited by pr-preview bot
Loading

@gkellogg gkellogg mentioned this pull request Dec 20, 2019
Closed
davidlehn
davidlehn reviewed Dec 20, 2019
View reviewed changes
@gkellogg
Copy link
Member

For #259.

gkellogg
gkellogg approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @davidlehn's suggested change.

@gkellogg gkellogg merged commit 753d2e9 into master Dec 20, 2019
@gkellogg gkellogg deleted the fix-259 branch December 20, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlehn davidlehn davidlehn left review comments

@gkellogg gkellogg gkellogg approved these changes

@dlongley dlongley Awaiting requested review from dlongley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchampin @gkellogg @davidlehn