Skip to content

Quotes aren't changed #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matteosuppo opened this issue Sep 3, 2016 · 4 comments
Closed

Quotes aren't changed #59

matteosuppo opened this issue Sep 3, 2016 · 4 comments

Comments

@matteosuppo
Copy link

Even if my tslint.json contains

        "quotemark": [
            true,
            "double"
        ],

tsfmt doesn't change a single quote to a double quote

@vvakame
Copy link
Owner

vvakame commented Sep 4, 2016

sounds good.
but tsfmt is wrapper of TypeScript Language Service.
I don't do that. sorry.

@darcyparker
Copy link

@matteosuppo and @vvakame - are you aware of a request to add the option to set the preferred quotemark (single or double) in ts.FormatCodeOptions? I couldn't find one here: https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue%20FormatCodeOptions and wanted to check with you before creating such a feature request.

@matteosuppo
Copy link
Author

I'm not aware of anything like that.

@joehannes-zz
Copy link

ping ... maybe I'm basically missing something else. but is this still valid. because I got the issue in my neovim-setup that when I neoformat with tsfmt I don't get the double quotes replaced by single quotes.
though the linter is showing errors, so nvim is picking the linting up.
don't know, maybe it's something else ... just, ping ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants