Skip to content

feat(plugin-meilisearch): add cli to generate only_urls #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 26, 2025

Conversation

JQiue
Copy link
Contributor

@JQiue JQiue commented Apr 29, 2025

…rator package

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

Screenshots

Before

After

@coveralls
Copy link

coveralls commented Apr 29, 2025

Pull Request Test Coverage Report for Build 15237397907

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.243%

Totals Coverage Status
Change from base Build 15235650963: 0.0%
Covered Lines: 1351
Relevant Lines: 2058

💛 - Coveralls

@Mister-Hope Mister-Hope changed the title feat(meilisearch-only-urls-generator): add meilisearch-only-urls-gene… feat(plugin-meilisearch): add cli to generate only_urls May 25, 2025
@Mister-Hope Mister-Hope force-pushed the feat/meilisearch-only-urls-generator branch from 8d8952a to 091b432 Compare May 25, 2025 06:54
@Mister-Hope
Copy link
Member

@JQiue Please review this.

@Mister-Hope Mister-Hope requested a review from pengzhanbo May 25, 2025 07:09
@Mister-Hope
Copy link
Member

Mister-Hope commented May 25, 2025

It would be possible to make this built-in with onGenerated hook (more performant🚀) but I am not sure if we shall throw when a changed markdown file was found unstaged.

Furthermore, users may have custom steps with deployment and it's possible for them to have a separate deploy step, which makes it hard to store the only_urls info.

@Mister-Hope Mister-Hope merged commit 22f13d1 into vuepress:main May 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants