-
Notifications
You must be signed in to change notification settings - Fork 70
feat(plugin-meilisearch): add cli to generate only_urls #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mister-Hope
merged 23 commits into
vuepress:main
from
JQiue:feat/meilisearch-only-urls-generator
May 26, 2025
Merged
feat(plugin-meilisearch): add cli to generate only_urls #446
Mister-Hope
merged 23 commits into
vuepress:main
from
JQiue:feat/meilisearch-only-urls-generator
May 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15237397907Details
💛 - Coveralls |
Mister-Hope
reviewed
Apr 30, 2025
8d8952a
to
091b432
Compare
@JQiue Please review this. |
It would be possible to make this built-in with onGenerated hook (more performant🚀) but I am not sure if we shall throw when a changed markdown file was found unstaged. Furthermore, users may have custom steps with deployment and it's possible for them to have a separate deploy step, which makes it hard to store the only_urls info. |
Mister-Hope
reviewed
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rator package
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Screenshots
Before
After