Skip to content

Can not have multiple meta "article:tag" #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
taichunmin opened this issue Sep 18, 2020 · 0 comments · May be fixed by #2615
Open
1 task done

Can not have multiple meta "article:tag" #2614

taichunmin opened this issue Sep 18, 2020 · 0 comments · May be fixed by #2615

Comments

@taichunmin
Copy link

taichunmin commented Sep 18, 2020 •
edited
Loading

  • I confirm that this is an issue rather than a question.

Bug report

meta article:tag is a array. Reference

By the way, there are more array type meta, not only article:tag.

Steps to reproduce

Write multiple meta article:tag in frontmatter

meta:
  - property: article:tag
    content: tag1
  - property: article:tag
    content: tag2
  - property: article:tag
    content: tag3

What is expected?

<meta property="article:tag" content="tag1">
<meta property="article:tag" content="tag2">
<meta property="article:tag" content="tag3">

What is actually happening?

<meta property="article:tag" content="tag1">

Other relevant information

vuepress/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js

Line 36 in 3c94f71

getMergedMetaTags () {

Need to patch getMergedMetaTags()
taichunmin added a commit to taichunmin/vuepress that referenced this issue Sep 18, 2020
@taichunmin
fix: Change union rule to array type meta vuejs#2614
8d6e870
taichunmin added a commit to taichunmin/vuepress that referenced this issue Sep 18, 2020
@taichunmin
fix: Change union rule to array type meta vuejs#2614
87f1bae
@taichunmin taichunmin linked a pull request Sep 18, 2020 that will close this issue
Open
18 tasks
taichunmin added a commit to taichunmin/vuepress that referenced this issue Oct 9, 2020
@taichunmin
fix: change meta tags merge function vuejs#2614
738ae57
taichunmin added a commit to taichunmin/vuepress that referenced this issue Oct 9, 2020
@taichunmin
fix: change meta tags merge function vuejs#2614
d9c8a61
taichunmin added a commit to taichunmin/vuepress that referenced this issue Oct 11, 2020
@taichunmin
fix: change meta tags merge function vuejs#2614
1823459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix($core): Change meta merge function #2614 taichunmin/vuepress
1 participant
@taichunmin