Skip to content

Conversation

kefranabg
Copy link
Collaborator

Summary

Fix #1748

New CI workflow introduced in this PR:

Capture d’écran 2019-08-08 à 12 13 19

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:
    Improving CI process

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

@kefranabg kefranabg requested a review from ulivz August 8, 2019 10:17
@kefranabg kefranabg force-pushed the feat/improve-ci-process branch 3 times, most recently from 7ada6b0 to dd008d3 Compare August 8, 2019 19:02
@kefranabg kefranabg force-pushed the feat/improve-ci-process branch from c1992c8 to 919d490 Compare August 11, 2019 17:47
@kefranabg kefranabg requested a review from sarahdayan August 11, 2019 18:02
@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

@kefranabg can you resolve the conflict and @sarahdayan valid the changes :). That i can add it to the release maybe ?

@flozero flozero added status: core team assigned Core team member assigned topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 6, 2019

you will need to resolve conflict here @kefranabg

@kefranabg kefranabg merged commit fe7301b into master Sep 7, 2019
@kefranabg kefranabg deleted the feat/improve-ci-process branch September 7, 2019 12:07
@vue-bot
Copy link

vue-bot commented Sep 7, 2019

Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: core team assigned Core team member assigned topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CircleCI workflow
4 participants