Skip to content

Conversation

vrjuliao
Copy link
Contributor

@vrjuliao vrjuliao commented Jul 29, 2019

I'm trying changing max suggestions like the link
https://vuepress.vuejs.org/default-theme-config/#search-box
But it was not work.

I fix this bug.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

I'm trying changing max suggestions like the link
https://vuepress.vuejs.org/default-theme-config/#search-box
But it was not work.

I fix this bug.
@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

Hello @vrjuliao ! Thank's for the PR Maybe it's more a bug coming into the constant. I will have a look at it soon.

@flozero flozero self-assigned this Sep 5, 2019
@flozero flozero added status: core team assigned Core team member assigned topic: config Relates to VuePress config topic: theme Relates to VuePress theme type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@flozero flozero changed the title Default theme is not work as expected search box max suggestions not working as expected Sep 7, 2019
@kefranabg
Copy link
Collaborator

Hi @vrjuliao,

Thanks for this PR 👍
Could you remove all the changes that concerns code formatting?
Let's focus on the maxSuggestion feature 😉

@flozero flozero added the need feedback Awaiting author response label Sep 10, 2019
@vrjuliao
Copy link
Contributor Author

hi @kefranabg, thanks for your suggestion. But, I didn't change the code formatting, I've just changed one line of code.

Now, I trying to resolve the conflicts and I see so many changes.
I guess these changes are contained on another pull request, like the semilcolon: commomnly I dont put it on the end lines in ECS code, however there are another than kind of this change type .

@vrjuliao
Copy link
Contributor Author

The code formating changes are made in this commit
7aa9753

The changes are not made by me, but I'm attending you solicitation.

@vrjuliao vrjuliao closed this Sep 10, 2019
@vrjuliao vrjuliao reopened this Sep 10, 2019
@vrjuliao vrjuliao changed the title search box max suggestions not working as expected fix: search box max suggestions not working as expected Sep 10, 2019
@kefranabg
Copy link
Collaborator

@vrjuliao Ok ! @f3ltron could you take a look ?

fix: pointer 'this' on searchBox is and commit name
@flozero
Copy link
Collaborator

flozero commented Sep 10, 2019

There is some code formating and it look's good to me for stylus i pref to have {} instead of nothing for readability.

a key not present in for loop. The thing i should not add that the "". But it will be corrected with the linter.

I valid this pr

@flozero flozero merged commit ade328f into vuejs:master Sep 10, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 10, 2019

thx @vrjuliao for your work 👍

@vue-bot
Copy link

vue-bot commented Sep 10, 2019

Hey @vrjuliao, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need feedback Awaiting author response status: core team assigned Core team member assigned topic: config Relates to VuePress config topic: theme Relates to VuePress theme type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants