Skip to content

feat(compiler-vapor): v-model for component #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

Jevon617
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit ef2b521
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6622589118bbaa00089795f4
😎 Deploy Preview https://deploy-preview-180--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit ef2b521
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/6622589182032d0009167919
😎 Deploy Preview https://deploy-preview-180--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 18, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.2 kB 24.7 kB
compiler-vapor.global.prod.js 52 kB (+590 B) 17.8 kB (+182 B) 16.1 kB (+157 B)
runtime-dom.global.prod.js 94.7 kB 35.6 kB 32.2 kB
runtime-vapor.global.prod.js 43 kB 16 kB 14.6 kB
vue-vapor.global.prod.js 92.4 kB (+591 B) 32.3 kB (+177 B) 29.2 kB (+128 B)
vue.global.prod.js 152 kB 55 kB 49.1 kB

Usages

Name Size Gzip Brotli
createApp 54.9 kB 21.1 kB 19.2 kB
createSSRApp 58.2 kB 22.4 kB 20.4 kB
defineCustomElement 57.2 kB 21.8 kB 19.9 kB
vapor 43.3 kB 16 kB 14.7 kB
overall 68.6 kB 26.1 kB 23.6 kB

@sxzz sxzz force-pushed the feat-comp-vmodel branch 2 times, most recently from d3e3ac3 to 2f30907 Compare April 18, 2024 17:14
@sxzz sxzz force-pushed the feat-comp-vmodel branch from 2f30907 to 578c122 Compare April 18, 2024 17:15
@sxzz
Copy link
Member

sxzz commented Apr 18, 2024

Could you please add some unit tests?

@Jevon617
Copy link
Contributor Author

Could you please add some unit tests?

Of course.

@sxzz sxzz merged commit 1f28ae1 into vuejs:main Apr 19, 2024
8 checks passed
@sxzz
Copy link
Member

sxzz commented Apr 19, 2024

Merged! Appreciate your amazing contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants