Skip to content

fix(compiler-vapor): v-on for component support $event argument #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Jevon617
Copy link
Contributor

@Jevon617 Jevon617 commented Apr 15, 2024

Currently, in <Foo @bar="handleBar($event)"> this case, compiler will prefix $event with _ctx wrongly.

image

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit ac0a148
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/661e3a899431d800076ecb87
😎 Deploy Preview https://deploy-preview-177--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit ac0a148
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/661e3a8984fd1200089cf090
😎 Deploy Preview https://deploy-preview-177--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 15, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 49.5 kB (+3 B) 16.9 kB (+15 B) 15.3 kB (+12 B)
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 42.8 kB 15.9 kB 14.6 kB
vue-vapor.global.prod.js 89.8 kB (+3 B) 31.3 kB (+12 B) 28.4 kB (+24 B)
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 43 kB 15.9 kB 14.6 kB
overall 68.5 kB 26.1 kB 23.6 kB

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

@sxzz sxzz merged commit e640ec6 into vuejs:main Apr 16, 2024
@sxzz sxzz changed the title feat(compiler-vapor): v-on for component support $event argument fix(compiler-vapor): v-on for component support $event argument Apr 16, 2024
@Jevon617 Jevon617 deleted the feat-comp-vOn branch April 16, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants