Skip to content

docs(name): Add link to deprecation explanation #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

travis5491811
Copy link
Contributor

@travis5491811 travis5491811 commented Mar 29, 2021

Closes #1745

Add reference to doc to explain to users why name is deprecated and what they should do next!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Doc update

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Just updating docs so new users don't abandon this project. This should also address #1745

Add reference to doc to explain to users why `name` is deprecated and what they should do next!
@afontcu
Copy link
Member

afontcu commented Mar 31, 2021

Hi! Thank you for this.

Looks like the link is not rendered as a link (because it is a markdown file):

imatge

Do you think you could update the PR to create a markdown link? [link text](url to link)

@afontcu afontcu changed the title Update name.md docs(name): Add link to deprecation explanation Mar 31, 2021
Updated to render link
@travis5491811
Copy link
Contributor Author

Hi! Thank you for this.

Looks like the link is not rendered as a link (because it is a markdown file):

imatge

Do you think you could update the PR to create a markdown link? [link text](url to link)

No problem. pull request updated.

@afontcu afontcu merged commit 245ba2a into vuejs:dev Mar 31, 2021
@afontcu
Copy link
Member

afontcu commented Mar 31, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is name() deprecated and what is the alternative?
2 participants