Skip to content

when mismatch version, it is better to fail the loader and webpack show error code #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

when mismatch version, it is better to fail the loader and webpack show error code #702

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82a5da
when vue and vue-template-compiler version mismatch, it should fail l…
sunlei33 Mar 9, 2017
7abcea6
fix code style
sunlei33 Mar 9, 2017
8a90e27
use friendly error message
sunlei33 Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/template-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ module.exports = function (html) {
options.transformToRequire
)
}

var compilerVersion = require('vue-template-compiler/package.json').version
var vueVersion = require('vue').version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably use vue/package.json here too to avoid evaluating Vue itself on startup.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit a patch for this PR


if(vueVersion !== compilerVersion){
this.emitError(`vue version ${vueVersion} mismatch vue-template-compiler version ${compilerVersion}`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the same language found here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit a patch for this PR

}

var compiled = compiler.compile(html, Object.assign({
preserveWhitespace: options.preserveWhitespace
Expand Down