Skip to content

Conversation

cvsguimaraes
Copy link

Please note the compiler interface use types that were added only in Vue 2.6 (vuejs/vue#7918), but folks with older versions of the template compiler shouldn't experience any errors, they will just not get type checking on compile and compileOptions properties.

@yyx990803 yyx990803 requested a review from haoqunjiang April 23, 2019 07:34
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are loader options, not plugin options.

@cvsguimaraes cvsguimaraes changed the title types: add plugin options declarations types: add loader options declarations Apr 23, 2019
@cvsguimaraes
Copy link
Author

@sodatea My bad, thanks!
There's any problem in force-pushing my own fork? I can recreate the PR if that's the case.

@yyx990803
Copy link
Member

@kbtzr you can just push. GitHub can auto-squash before merging.

@cvsguimaraes
Copy link
Author

@sodatea it seems that your request for changes got stuck on ea26afa that got overwritten by my force push. I'm closing this PR in favor of #1542, sorry for the confusion its one of my first PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants