Skip to content

fix getting shadow root when component is functional #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2020
Merged

fix getting shadow root when component is functional #1560

merged 1 commit into from
May 1, 2020

Conversation

zrh122
Copy link

@zrh122 zrh122 commented Jun 21, 2019

Add fetching $root from parent because functional components' context doesn't have the $root property. It will close issue.

@zrh122 zrh122 mentioned this pull request Jun 21, 2019
Closed
@Marcus-Rise
Copy link

Marcus-Rise commented Apr 28, 2020 •
edited
Loading

@sodatea Still waiting for accepting PR from @zrh122

@haoqunjiang haoqunjiang merged commit 9a7357a into vuejs:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Components with Functional child components throws "Cannot read property '$options' of undefined"
3 participants
@zrh122 @Marcus-Rise @haoqunjiang