Add eslint configuration tab #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
force-pushed
the
add-eslint-configuration-tab
branch
from
78048db to
80d2c59
Compare
Akryum
reviewed
Jul 31, 2018
| @@ -12,7 +12,7 @@ | |||
| </div> | |||
| <div v-if="description || link || showDescription" class="description"> | |||
| <slot name="description"> | |||
| <span v-html="description"/> | |||
There was a problem hiding this comment.
Description of some rules contain <tagname> and it broked the UI 🤔
|
Seems like because of network issues the build failed. Can you please @Akryum rerun the build from CircleCI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1423
This PR updates the configuration tab for
@vue/cli-plugin-eslintin vue-ui.Original proposition: vuejs/eslint-plugin-vue#477
It adds a
generaltab with two settings, where users can both setlint on saveand choose one of the pre-defined configs:It add a
rulestab with a list of all rules and categories:When user selects certain category in
generaltab - lets' saystrongly-recommendedwe seterrorasdefaultvalue for all rules inbase,essentialandstrongly-recommendedcategories.At the very bottom we also have a list of
Uncategorizedrules, that are always off by default.Due to the fact that it's really hard, and currently impossible to generate controls that would allow full configuration regarding actual rules' schemas we allow setting only
error,warningandoff. If the user wants he can customize rules further using.eslintrc, then if the rule has custom settings, we display its value in dropdown ascustom- but this option appears only if the rule has been reconfigured.Whenever user changes the configuration in
generaltab, to not introduce confusion we're not resetting any custom settings, that user might've set himself before.cc @chrisvfritz