feat: shallow mount #107
Merged
feat: shallow mount #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
reviewed
May 4, 2020
There was a problem hiding this comment.
That was easy - mainly since you did all the hard work in stubs. Awesome!
Should we include a shallowMount function too, perhaps with a message "please use the shallow option. `shallowMount will be removed in a future release"? That might be useful for migration purposes.
shallow: true feels super clean to me! Not sure how others feel - happy to have a discussion around this if people feel strongly about a top level shallowMount method.
|
I think we move to beta once this is merged and docs are up to date. |
lmiller1990
approved these changes
May 5, 2020
|
I dont think so.. I dont know if there is a point to add more tests. It is just mount with stubs :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic implementation for
shallowMountviaMountOptions.shallowI still need to add tests, but it seems to work great.
resolves #6