Skip to content

perf(extension): skip some extra condition #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2023
Merged

perf(extension): skip some extra condition #3781

merged 1 commit into from
Dec 26, 2023

Conversation

Simon-He95
Copy link
Contributor

No description provided.

so1ve
so1ve reviewed Dec 6, 2023
View reviewed changes
so1ve
so1ve reviewed Dec 6, 2023
View reviewed changes
extensions/vscode/src/features/nameCasing.ts Outdated
Comment on lines 215 to 218
else {
text += '? ';
}
if (attrNameCasing === AttrNameCasing.Kebab) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't wake up

@johnsoncodehk johnsoncodehk force-pushed the master branch 3 times, most recently from 3303eea to 4fb5cd4 Compare December 26, 2023 11:34
@johnsoncodehk johnsoncodehk merged commit 51e0aec into vuejs:master Dec 26, 2023
johnsoncodehk pushed a commit that referenced this pull request Dec 27, 2023
@Simon-He95 @johnsoncodehk
perf(extension): skip some extra condition (#3781)
7e1a61c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@so1ve so1ve so1ve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simon-He95 @so1ve @johnsoncodehk