Skip to content

Migrate circleci to version 2 #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2018
Merged

Migrate circleci to version 2 #603

merged 4 commits into from
Nov 6, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Oct 11, 2018 •
edited
Loading

Migrate circleci to version 2

mysticatea
mysticatea reviewed Oct 20, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Looks like good to me.
But I want more set of eyes since I'm not familiar with Circle CI.

@armano2
Copy link
Contributor Author

armano2 commented Oct 27, 2018

After merging this commit there are 2 choices to make:

  1. You cans till use current setting for builds
  2. You can use new github checks: https://circleci.com/docs/2.0/enable-checks/

michalsnik
michalsnik approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job @armano2

@michalsnik michalsnik merged commit 2ddcec9 into vuejs:master Nov 6, 2018
@armano2 armano2 deleted the circleci2 branch November 6, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea left review comments

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armano2 @mysticatea @michalsnik