refactor: optimize code

Author: chouchouji

lib/rules/no-ref-as-operand.js

@@ -81,6 +81,21 @@ module.exports = {
     let refReferences
     const setupContexts = new Map()
 
+    /**
+     * Collect identifier id
+     * @param {Identifier} node
+     * @param {Set<Identifier>} referenceIds
+     */
+    function collectReferenceIds(node, referenceIds) {
+      const variable = findVariable(utils.getScope(context, node), node)
+      if (!variable) {
+        return
+      }
+      for (const reference of variable.references) {
+        referenceIds.add(reference.identifier)
+      }
+    }
+
     /**
      * @param {Identifier} node
      */
@@ -101,6 +116,16 @@ module.exports = {
       })
     }
 
+    /**
+     * @param {CallExpression} node
+     */
+    function reportWrappedIdentifiers(node) {
+      const nodes = node.arguments.filter((node) => node.type === 'Identifier')
+      for (const node of nodes) {
+        reportIfRefWrapped(node)
+      }
+    }
+
     const programNode = context.getSourceCode().ast
 
     const callVisitor = {
@@ -117,35 +142,27 @@ module.exports = {
 
         // verify setup context
         const setupContext = setupContexts.get(info ? info.node : programNode)
-        if (setupContext) {
-          const { contextReferenceIds, emitReferenceIds } = setupContext
+        if (!setupContext) {
+          return
+        }
+
+        const { contextReferenceIds, emitReferenceIds } = setupContext
+        if (
+          node.callee.type === 'Identifier' &&
+          emitReferenceIds.has(node.callee)
+        ) {
+          // verify setup(props,{emit}) {emit()}
+          reportWrappedIdentifiers(node)
+        } else {
+          const emit = getCalleeMemberNode(node)
           if (
-            node.callee.type === 'Identifier' &&
-            emitReferenceIds.has(node.callee)
+            emit &&
+            emit.name === 'emit' &&
+            emit.member.object.type === 'Identifier' &&
+            contextReferenceIds.has(emit.member.object)
           ) {
-            // verify setup(props,{emit}) {emit()}
-            const nodes = node.arguments.filter(
-              (node) => node.type === 'Identifier'
-            )
-            for (const node of nodes) {
-              reportIfRefWrapped(node)
-            }
-          } else {
-            const emit = getCalleeMemberNode(node)
-            if (
-              emit &&
-              emit.name === 'emit' &&
-              emit.member.object.type === 'Identifier' &&
-              contextReferenceIds.has(emit.member.object)
-            ) {
-              // verify setup(props,context) {context.emit()}
-              const nodes = node.arguments.filter(
-                (node) => node.type === 'Identifier'
-              )
-              for (const node of nodes) {
-                reportIfRefWrapped(node)
-              }
-            }
+            // verify setup(props,context) {context.emit()}
+            reportWrappedIdentifiers(node)
           }
         }
       }
@@ -253,17 +270,9 @@ module.exports = {
           }
 
           // const emit = defineEmits()
-          const variable = findVariable(
-            utils.getScope(context, emitParam),
-            emitParam
-          )
-          if (!variable) {
-            return
-          }
           const emitReferenceIds = new Set()
-          for (const reference of variable.references) {
-            emitReferenceIds.add(reference.identifier)
-          }
+          collectReferenceIds(emitParam, emitReferenceIds)
+
           setupContexts.set(programNode, {
             contextReferenceIds: new Set(),
             emitReferenceIds
@@ -285,6 +294,7 @@ module.exports = {
             // cannot check
             return
           }
+
           const contextReferenceIds = new Set()
           const emitReferenceIds = new Set()
           if (contextParam.type === 'ObjectPattern') {
@@ -295,30 +305,12 @@ module.exports = {
             if (!emitProperty || emitProperty.value.type !== 'Identifier') {
               return
             }
-            const emitParam = emitProperty.value
+
             // `setup(props, {emit})`
-            const variable = findVariable(
-              utils.getScope(context, emitParam),
-              emitParam
-            )
-            if (!variable) {
-              return
-            }
-            for (const reference of variable.references) {
-              emitReferenceIds.add(reference.identifier)
-            }
+            collectReferenceIds(emitProperty.value, emitReferenceIds)
           } else {
             // `setup(props, context)`
-            const variable = findVariable(
-              utils.getScope(context, contextParam),
-              contextParam
-            )
-            if (!variable) {
-              return
-            }
-            for (const reference of variable.references) {
-              contextReferenceIds.add(reference.identifier)
-            }
+            collectReferenceIds(contextParam, contextReferenceIds)
           }
           setupContexts.set(vueNode, {
             contextReferenceIds,