refactor: optimize code

Author: chouchouji

lib/rules/no-ref-as-operand.js

@@ -101,6 +101,16 @@ module.exports = {
       })
     }
 
+    /**
+     * @param {CallExpression} node
+     */
+    function reportWrappedIdentifiers(node) {
+      const nodes = node.arguments.filter((node) => node.type === 'Identifier')
+      for (const node of nodes) {
+        reportIfRefWrapped(node)
+      }
+    }
+
     const programNode = context.getSourceCode().ast
 
     const callVisitor = {
@@ -117,35 +127,27 @@ module.exports = {
 
         // verify setup context
         const setupContext = setupContexts.get(info ? info.node : programNode)
-        if (setupContext) {
-          const { contextReferenceIds, emitReferenceIds } = setupContext
+        if (!setupContext) {
+          return
+        }
+
+        const { contextReferenceIds, emitReferenceIds } = setupContext
+        if (
+          node.callee.type === 'Identifier' &&
+          emitReferenceIds.has(node.callee)
+        ) {
+          // verify setup(props,{emit}) {emit()}
+          reportWrappedIdentifiers(node)
+        } else {
+          const emit = getCalleeMemberNode(node)
           if (
-            node.callee.type === 'Identifier' &&
-            emitReferenceIds.has(node.callee)
+            emit &&
+            emit.name === 'emit' &&
+            emit.member.object.type === 'Identifier' &&
+            contextReferenceIds.has(emit.member.object)
           ) {
-            // verify setup(props,{emit}) {emit()}
-            const nodes = node.arguments.filter(
-              (node) => node.type === 'Identifier'
-            )
-            for (const node of nodes) {
-              reportIfRefWrapped(node)
-            }
-          } else {
-            const emit = getCalleeMemberNode(node)
-            if (
-              emit &&
-              emit.name === 'emit' &&
-              emit.member.object.type === 'Identifier' &&
-              contextReferenceIds.has(emit.member.object)
-            ) {
-              // verify setup(props,context) {context.emit()}
-              const nodes = node.arguments.filter(
-                (node) => node.type === 'Identifier'
-              )
-              for (const node of nodes) {
-                reportIfRefWrapped(node)
-              }
-            }
+            // verify setup(props,context) {context.emit()}
+            reportWrappedIdentifiers(node)
           }
         }
       }
@@ -285,6 +287,7 @@ module.exports = {
             // cannot check
             return
           }
+
           const contextReferenceIds = new Set()
           const emitReferenceIds = new Set()
           if (contextParam.type === 'ObjectPattern') {