refactor: optimize code

Author: chouchouji

lib/rules/no-ref-as-operand.js

@@ -124,11 +124,12 @@ module.exports = {
             emitReferenceIds.has(node.callee)
           ) {
             // verify setup(props,{emit}) {emit()}
-            node.arguments
-              .filter((node) => node.type === 'Identifier')
-              .forEach((node) => {
-                reportIfRefWrapped(node)
-              })
+            const nodes = node.arguments.filter(
+              (node) => node.type === 'Identifier'
+            )
+            for (const node of nodes) {
+              reportIfRefWrapped(node)
+            }
           } else {
             const emit = getCalleeMemberNode(node)
             if (
@@ -138,11 +139,12 @@ module.exports = {
               contextReferenceIds.has(emit.member.object)
             ) {
               // verify setup(props,context) {context.emit()}
-              node.arguments
-                .filter((node) => node.type === 'Identifier')
-                .forEach((node) => {
-                  reportIfRefWrapped(node)
-                })
+              const nodes = node.arguments.filter(
+                (node) => node.type === 'Identifier'
+              )
+              for (const node of nodes) {
+                reportIfRefWrapped(node)
+              }
             }
           }
         }
@@ -235,101 +237,99 @@ module.exports = {
           reportIfRefWrapped(node)
         }
       },
-      utils.compositingVisitors(
-        utils.defineScriptSetupVisitor(context, {
-          onDefineEmitsEnter(node) {
-            if (
-              !node.parent ||
-              node.parent.type !== 'VariableDeclarator' ||
-              node.parent.init !== node
-            ) {
-              return
-            }
+      utils.defineScriptSetupVisitor(context, {
+        onDefineEmitsEnter(node) {
+          if (
+            !node.parent ||
+            node.parent.type !== 'VariableDeclarator' ||
+            node.parent.init !== node
+          ) {
+            return
+          }
+
+          const emitParam = node.parent.id
+          if (emitParam.type !== 'Identifier') {
+            return
+          }
 
-            const emitParam = node.parent.id
-            if (emitParam.type !== 'Identifier') {
+          // const emit = defineEmits()
+          const variable = findVariable(
+            utils.getScope(context, emitParam),
+            emitParam
+          )
+          if (!variable) {
+            return
+          }
+          const emitReferenceIds = new Set()
+          for (const reference of variable.references) {
+            emitReferenceIds.add(reference.identifier)
+          }
+          setupContexts.set(programNode, {
+            contextReferenceIds: new Set(),
+            emitReferenceIds
+          })
+        },
+        ...callVisitor
+      }),
+      utils.defineVueVisitor(context, {
+        onSetupFunctionEnter(node, { node: vueNode }) {
+          const contextParam = utils.skipDefaultParamValue(node.params[1])
+          if (!contextParam) {
+            // no arguments
+            return
+          }
+          if (
+            contextParam.type === 'RestElement' ||
+            contextParam.type === 'ArrayPattern'
+          ) {
+            // cannot check
+            return
+          }
+          const contextReferenceIds = new Set()
+          const emitReferenceIds = new Set()
+          if (contextParam.type === 'ObjectPattern') {
+            const emitProperty = utils.findAssignmentProperty(
+              contextParam,
+              'emit'
+            )
+            if (!emitProperty || emitProperty.value.type !== 'Identifier') {
               return
             }
-
-            // const emit = defineEmits()
+            const emitParam = emitProperty.value
+            // `setup(props, {emit})`
             const variable = findVariable(
               utils.getScope(context, emitParam),
               emitParam
             )
             if (!variable) {
               return
             }
-            const emitReferenceIds = new Set()
             for (const reference of variable.references) {
               emitReferenceIds.add(reference.identifier)
             }
-            setupContexts.set(programNode, {
-              contextReferenceIds: new Set(),
-              emitReferenceIds
-            })
-          },
-          ...callVisitor
-        }),
-        utils.defineVueVisitor(context, {
-          onSetupFunctionEnter(node, { node: vueNode }) {
-            const contextParam = utils.skipDefaultParamValue(node.params[1])
-            if (!contextParam) {
-              // no arguments
-              return
-            }
-            if (
-              contextParam.type === 'RestElement' ||
-              contextParam.type === 'ArrayPattern'
-            ) {
-              // cannot check
+          } else {
+            // `setup(props, context)`
+            const variable = findVariable(
+              utils.getScope(context, contextParam),
+              contextParam
+            )
+            if (!variable) {
               return
             }
-            const contextReferenceIds = new Set()
-            const emitReferenceIds = new Set()
-            if (contextParam.type === 'ObjectPattern') {
-              const emitProperty = utils.findAssignmentProperty(
-                contextParam,
-                'emit'
-              )
-              if (!emitProperty || emitProperty.value.type !== 'Identifier') {
-                return
-              }
-              const emitParam = emitProperty.value
-              // `setup(props, {emit})`
-              const variable = findVariable(
-                utils.getScope(context, emitParam),
-                emitParam
-              )
-              if (!variable) {
-                return
-              }
-              for (const reference of variable.references) {
-                emitReferenceIds.add(reference.identifier)
-              }
-            } else {
-              // `setup(props, context)`
-              const variable = findVariable(
-                utils.getScope(context, contextParam),
-                contextParam
-              )
-              if (!variable) {
-                return
-              }
-              for (const reference of variable.references) {
-                contextReferenceIds.add(reference.identifier)
-              }
+            for (const reference of variable.references) {
+              contextReferenceIds.add(reference.identifier)
             }
-            setupContexts.set(vueNode, {
-              contextReferenceIds,
-              emitReferenceIds
-            })
-          },
-          ...callVisitor,
-          onVueObjectExit(node) {
-            setupContexts.delete(node)
           }
-        })
-      )
+          setupContexts.set(vueNode, {
+            contextReferenceIds,
+            emitReferenceIds
+          })
+        },
+        ...callVisitor,
+        onVueObjectExit(node) {
+          setupContexts.delete(node)
+        }
+      })
     )
   }
 }