Skip to content

Mention application mounting changes in migration guide and API #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 10, 2021
Merged

Mention application mounting changes in migration guide and API #936

merged 12 commits into from
Mar 10, 2021

Conversation

NataliaTepluhina
Copy link
Member

Close #924

@LinusBorg LinusBorg self-assigned this Mar 9, 2021
LinusBorg
LinusBorg approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, just found some grammar nitpicks here and there, see comments!

@LinusBorg LinusBorg removed their assignment Mar 9, 2021
@NataliaTepluhina NataliaTepluhina merged commit 3147cc5 into master Mar 10, 2021
@NataliaTepluhina NataliaTepluhina deleted the fix-mount-api branch March 10, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

@skirtles-code skirtles-code Awaiting requested review from skirtles-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Migration]: Vue 3 doesn't replace the element it mounts to
2 participants
@NataliaTepluhina @LinusBorg