Switch the reactivity/proxies CodePen to the Vue account #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761.
I've migrated this CodePen to the main Vue account, fixing a couple of problems in the process.
Previously, clicking the green Replay button at the end would fail (see #761). This attempted to reload the iframe, which for various reasons doesn't work. I tried some direct replacements but none of those seemed any better.
Instead I tweaked the code to perform a manual reset. Most of the code was already wrapped in functions but I wrapped the remaining code in a function called
init. I also grabbed the initialinnerHTMLfor the main content. Clicking the Replay button now sets theinnerHTMLback to its initial value before rerunning all the same functions that are run when the page first loads.I also adjusted one of the CSS
heightvalues from400pxto320px. Previously I was seeing a vertical scrollbar for this example and reducing that value seems to be enough to get rid of it. The animation itself should be unaffected as the extra space was empty.