Explain how to omit dynamic attributes #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaTepluhina
approved these changes
Dec 13, 2020
fimion
pushed a commit
to fimion/docs-next
that referenced
this pull request
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Some values cause dynamic attributes to be omitted. The current description of this in
template-syntax.mdis not entirely accurate.Proposed Solution
The tricky part of explaining this is the handling of an empty string for boolean attributes. My explanation of why it behaves the way it does is very brief but I didn't want to dwell on an edge case. I hope I've provided enough information for those who are curious without derailing those who aren't.
Additional Information
Closes #711.