-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: added created
hook to directives
#719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some thoughts to a couple of lines.
As an aside, it seems I'm to blame for adding a lot of unnecessary spaces at the ends of lines. My text editor is faithfully respecting the settings in .editorconfig
, which includes the following:
[*.md]
trim_trailing_whitespace = false
I understand why it's there but it is causing these extra spaces in some of my contributions. Locally I've now hacked that file so, hopefully, any future changes will be trimmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This has been buzzing around at the back of my mind all week but I wasn't able to think of a way to write it that I'm entirely happy with.
I've made some concrete suggestions this time. I've removed any mention of the parent component or props and have instead used the phrase 'element's attributes or event listeners'. I think that's an accurate description and conveys it in a way that will be relatable to most readers.
Co-authored-by: skirtle <[email protected]>
Co-authored-by: skirtle <[email protected]>
Co-authored-by: skirtle <[email protected]>
* feat: added `created` hood to directives * Update src/api/application-api.md Co-authored-by: skirtle <[email protected]> * Update src/guide/custom-directive.md Co-authored-by: skirtle <[email protected]> * Update src/guide/migration/custom-directives.md Co-authored-by: skirtle <[email protected]> * fix: updated the beforeMount description Co-authored-by: skirtle <[email protected]>
Description of Problem
Current documentation misses the
created
custom directives hook added in vuejs/core@11804feProposed Solution
I've added a new hook to API, Migration guide and Guide
/close #430