fix, minor grammar. some comma #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first comma in the senctence seems oddly placed. This makes the sentence hard to understand at first. For me at least. I think that first comma should not be between *store* and *but* but between *convention* and *where*.
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
The first comma in the senctence seems oddly placed. This makes the sentence hard to understand at first. For me at least. I think that first comma should not be between *store* and *but* but between *convention* and *where*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The first comma in the senctence seems oddly placed. This makes the sentence hard to understand at first. For me at least.
Proposed Solution
I think that first comma should not be between store and but but between convention and where.
Additional Information
This comma even got itself some
researchgoogling:Comma Rules: A Quick Guide | Grammarly
Cheers!