fix, minor grammar. first-class citizen #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd think that 'It has a [...] support.' does not sound right. So either; 1) 'It has a first-class citizens' support', or 2) 'It has first-class citizen support' may fit better? Option 2) technically means that first-class citizens support it. So I guess option 1) is the way to go. I'm not a native english speaker, so forgive me for wasting your time if I'm wrong altogether. Cheers!
skirtles-code
approved these changes
Oct 1, 2020
|
Should I now do anything else or will the cosmos take it from here? |
|
@bambalamm The change looks good to me but you'll need to wait for someone with merge rights to review it. Nothing needed from you until then. |
NataliaTepluhina
approved these changes
Oct 3, 2020
There was a problem hiding this comment.
@bambalamm thank you for the fix! Happy to be the cosmos moving this PR to merge 🎉
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
* fix, minor grammar. first-class citizen I'd think that 'It has a [...] support.' does not sound right. So either; 1) 'It has a first-class citizens' support', or 2) 'It has first-class citizen support' may fit better? Option 2) technically means that first-class citizens support it. So I guess option 1) is the way to go. I'm not a native english speaker, so forgive me for wasting your time if I'm wrong altogether. Cheers! * Update typescript-support.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
From typescript-support.md:
This means you don't need any additional tooling to use TypeScript with Vue - it has a first-class citizen support.I'd think that 'It has a [...] support.' does not sound right here.
Proposed Solution
So either; 1) It has a first-class citizens' support, or 2) It has first-class citizen support may fit better?
Option 2) technically means that first-class citizens support it. So I'd guess option 1) is the way to go.
Additional Information
I'm not a native english speaker, so forgive me for wasting your time if I'm wrong altogether.
Cheers!