Skip to content

fix: improve component attrs section #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Sep 23, 2020

Description of Problem

The documentation says that $attrs can be accessed by setting inheritAttrs: false.
However, $attrs can be accessed with or without inheritAttrs setting.

The rfcs says the following:

this.$attrs (and context.attrs for setup() and functional components) now contains all attributes passed to the component (as long as it is not declared as props).

https://github.com/vuejs/rfcs/blob/master/active-rfcs/0031-attr-fallthrough.md#inheritattrs-false

Proposed Solution

Remove the following sentence and add the new sentence of this PR, or we change to another explanation.

Additional Information

I hope that you update my docs is wrote with my poor English! 🙇

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazupon thank you for the fix! Looks perfect to me 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants