fix: use current event modifiers syntax in render function #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@visualfanatic It looks like the changes you were proposing are quite similar to #552, which has now been merged. Given the current conflicts, I think it would be best to close this PR. Do you agree? I can't speak for anyone else but I think it would be remiss of me to suggest closing this PR without also acknowledging the long delay in giving you any feedback. I dare say that's quite frustrating for you. I don't know why that happened but my guess would be that there was a good reason why it couldn't be merged immediately and then it got forgotten about. My own feeling is that this is more likely to happen when there are a lot of open PRs, so I'm trying to help out by reviewing all the old PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
.passive,.captureand.onceevent modifiers JSX-friendly, the syntax was recently changed to allow passing them in the camelCase notation right after the event name. I added the note about combining them and extended the example to include the.passiveevent modifier just in case.