Skip to content

Update introduction.md #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Update introduction.md #1306

merged 1 commit into from
Oct 30, 2021

Conversation

wxsms
Copy link
Member

@wxsms wxsms commented Oct 30, 2021

remove strange markups. this paragraph is already shown on page.

remove strange markups
@NataliaTepluhina NataliaTepluhina merged commit d026fc2 into vuejs:master Oct 30, 2021
@skirtles-code
Copy link
Contributor

I don't think this paragraph, or the one that follows it, are supposed to be shown. I'm pretty sure they weren't visible when the page was first added, so I suspect a dependency change could be to blame. I would imagine that standard HTML comments would hide them?

@wxsms
Copy link
Member Author

wxsms commented Oct 31, 2021

I don't think this paragraph, or the one that follows it, are supposed to be shown. I'm pretty sure they weren't visible when the page was first added, so I suspect a dependency change could be to blame. I would imagine that standard HTML comments would hide them?

as I see from the git history, it's written by @NataliaTepluhina , and this paragraph had not change since it was added. which means it was shown from the beginning.

@skirtles-code
Copy link
Contributor

My theory was that it was originally hidden and it was revealed later due to upgrading VuePress. However, I just checked the original test deployment at https://deploy-preview-864--vue-docs-v3-legacy.netlify.app/guide/ssr/introduction.html#about-this-guide and that doesn't appear to be the case. It has, indeed, been there from the start.

That said, it definitely wasn't meant to be showing. It was discussed on the original PR and the intention was to hide it, which is what those extra characters were supposed to be do: #864 (comment). Even though there is now a version of Nuxt that supports Vue 3, it isn't yet production ready so the description given in that paragraph is still a bit misleading.

@wxsms
Copy link
Member Author

wxsms commented Oct 31, 2021

Ah. So it's a mistake to be shown. Please help yourself for that if you wish. I just make it display better while the fact is it's already displaying.

@Justineo
Copy link
Member

Justineo commented Nov 1, 2021

As Nuxt 3 beta is now live maybe we shall update the link to https://v3.nuxtjs.org/ so we don't need to hide it now.

@skirtles-code
Copy link
Contributor

@Justineo I'll put in a PR to update the link and tweak the wording to reflect the beta status of Nuxt 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants