Script Setup Edits for Clarity #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
suggested changes
Aug 26, 2021
There was a problem hiding this comment.
Thanks for the PR!
Personally, I aim to use we as much as possible, using you only in cases where we feels unnatural. But most of this page doesn't seem to have been written in that style, so keeping the page consistent is probably for the best.
If you can accept the proposed change to the URLs then I'd be happy to approve this PR.
Co-authored-by: skirtle <[email protected]>
skirtles-code
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The
<script setup>documentation sometimes usedweand sometimes usedyou.The
<script setup>documentation was unclear about whetherdefinePropswas the only way to define props in<script setup>; it referred to the "props option," making it ambiguous about whether that option would still be in use.Proposed Solution
Edits for clarity below.
Additional Information