Skip to content

Correct vue.config.js example #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

lindsaykwardell
Copy link
Contributor

A bracket is missing from the vue.config.js configuration example, this change would add in the missing bracket so the code example is valid.

Description of Problem

In the code example for vue.config.js to add the compat rule, a bracket is missing which results in an error when copy/pasted.

Proposed Solution

The proposed solution would be to add in the bracket, so that the code example is correct and valid.

Additional Information

A bracket is missing from the vue.config.js configuration example, this change would add in the missing bracket so the code example is valid.
@skirtles-code
Copy link
Contributor

Looks good. Thanks for the fix.

@skirtles-code skirtles-code merged commit 28a141c into vuejs:master Jun 18, 2021
@catrope
Copy link

catrope commented Jul 21, 2021

I just attempted to submit this same fix before finding that this had already been fixed ~6 weeks ago. Apparently the deployed version has not been updated in that time, because it still has this syntax error.

@skirtles-code
Copy link
Contributor

@catrope The docs deploy automatically when changes are merged. Perhaps you're seeing a cached version? The 'Last updated' time at the bottom of that page should read '2021-07-13, 16:56:51 UTC'.

@catrope
Copy link

catrope commented Jul 22, 2021

I guess I must have seen a cached version somehow. I just opened the same page again and it looks right this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants