The description of this in setup is inconsistent with the source code
#1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
suggested changes
May 24, 2021
There was a problem hiding this comment.
@coderwhy. Thanks for the PR!
I agree that the current explanation is a little misleading.
I've made some suggestions on your proposed changes below.
| required: true | ||
| } | ||
| required: true, | ||
| }, |
There was a problem hiding this comment.
Could you please revert all of the unrelated formatting changes?
There was a problem hiding this comment.
I have submitted an inappropriate modification about the comma, thank you for pointing it out
coderwhy
commented
May 24, 2021
skirtles-code
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
According to the content of the vue3 source code, the component instance has been created when the setup is executed.
But the description in the document is not created, so
thiscannot be used.According to the original,
thiscannot be used because this is not bound to this during setup, and props, etc. cannot be used because options such as props, data, compute, etc. will be processed later.Proposed Solution
Modified the description information, which is relatively more accurate and will not cause misunderstandings.
Additional Information
Thanks for the excellent documentation.