Skip to content

Update custom-directive.md #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2021
Merged

Update custom-directive.md #1058

merged 2 commits into from
May 25, 2021

Conversation

fanhefeng
Copy link
Contributor

Optimization. I think it'll be better.

Description of Problem

Proposed Solution

Additional Information

Optimization. I think it'll be better.
@Alex-Sokolov
Copy link
Contributor

@fanhefeng why not direction || 'top'?

@NataliaTepluhina
Copy link
Member

@fanhefeng thank you for the contribution. I've implemented @Alex-Sokolov suggestion, as I believe it's more readable.

@NataliaTepluhina NataliaTepluhina merged commit 6efc0ce into vuejs:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants