Transition hooks #1175
Closed
Transition hooks #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
commented
May 16, 2020
| onLeaveCancelled(el) { | ||
| finishLeave(el) | ||
| callHook(onLeaveCancelled, [el]) | ||
| } |
There was a problem hiding this comment.
This is fix the bug wihch never called onEnterCancelled and onLeaveCancelled hooks
| onEnter, | ||
| onBeforeEnter, | ||
| onEnterCancelled | ||
| ] = originEnterHook | ||
| } |
There was a problem hiding this comment.
Here is fix bug which never called the related appear hooks
underfin
commented
May 16, 2020
| export type TransitionOtherHook<HostElement = RendererElement> = ( | ||
| el: HostElement | ||
| ) => void | ||
|
|
There was a problem hiding this comment.
I think it's helpful for re-use type.But i'm not sure your opinion
|
Does #1151 contain tests for this? |
|
#1151 has been merged - can you rebase on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
appearprops, and add appear hooks props intoBaseTransitionProps.2.Should call
onLeaveCancelledandonEnterCancelledhook.Feature
BaseTransition. because it will throw error with wrapped function inTransition.It is should happend in user provider hooks.